Skip to content

Security audit for collections royalties marketplaces

EnactedGrant Request

Proposal Details

Author0x8795…26ed
PublishedNov 13, 2021 23:14
Voting beginsNov 13, 2021 23:14
Voting endsNov 20, 2021 23:14
Snapshot#NVXwNJU

Grant size

30,000 USD

Tier

Tier 4

Beneficiary

0xBCAc…7eDA

Description

Based on the proposal passed [here](https://governance.decentraland.org/proposal/?id=b70c59d0-09c5-11ec-a4d1-8d5d2cba0825) + some free time I took the chance to upgrade the implementation of the Marketplace & Bid smart contracts to include royalties for collection creators/item beneficiaries. It is **ONLY IN POLYGON** where UG collections are being created. For the time being, royalties are going to be calculated following: - Each token is an item kind. You may know that each item can have a beneficiary which is used for primary sales. If the item has a beneficiary, the royalties will go to the item's beneficiary. If not. - Royalties will go to the collection creator. The implementation of how the royalties receiver is calculated can be easily replaced by a new one. To understand how it can be done if you are tech, refer [here](https://github.com/decentraland/marketplace-contracts/blob/feat/marketplace-with-royalties/contracts/managers/RoyaltiesManager.sol) The royalty will be 2.5%. The smart contracts still support the current fee for the DAO but is going to be 0%. I decided to keep it if for some reason we need to have something like 1% for the DAO and 1.5% for creators. The Grant amount can change. I've set a cap. I'm still waiting for the auditors' quote.

Voting Power

00.5M1MRequired to pass11/1311/1511/1711/1811/20
YesNo

1 Comments

daoAug 09, 2022

Security audit for collections royalties marketplaces This proposal has been ENACTED by a DAO Committee Member (0xfe91c0c482e09600f2d1dbca10fd705bc6de60bc) Vesting Contract not created. Paid directly to address 0x7C6Eda316FC4aBf1efaBA8015e6Ff04B241fcb35 in USDT. [View Transaction](https://etherscan.io/tx/0x805f395630fbdbe319ac184b9354eab42f5b7ffd35a362c40ffba7a8cbe1cc32) Pessimistic audit 6k * [TX 1](https://etherscan.io/tx/0xd1f2b8374f710850963d4322b7c44a3f1f455ff50e870ac7e47734c6d4f94124) * [TX 2](https://etherscan.io/tx/0xa8d45c86e7b34f9c32ade7411782e4cea17ac8e45527038cb65a0d3878666f33) * [Report 1](https://hackmd.io/@pessimistic/B1gZ-ZR9t) and [Report 2](https://hackmd.io/@pessimistic/rk_31kcst) Certik audit 24k: * [TX 1](https://etherscan.io/tx/0x29bad8ce30296214ded7cb97b7b2ac96a6b88ecca7b10864722ca0301332fc13) * [TX 2](https://etherscan.io/tx/0xe17735284486da39c81e7e2650831c4014d7a30cf290e5e44761d8fecbd42f2d) * [Report](https://github.com/decentraland/smart-contract-audits/blob/master/reports/Decentraland_Marketplace_and_Bids_V2_With_Royalties_Certik_12_03_2021.pdf)